search

Hertzole / gold-player

A first person player controller for Unity.
MIT License
160 stars 16 forks source link

Error when on any Unity Version earlier than 2019.3, and not using the new Input System. #30

Closed ruudschouten closed 4 years ago

ruudschouten commented 4 years ago

In the GoldPlayerTests class I get an error because the MovingPlatforms.Initialize() method always needs two parameters.

#if ENABLE_INPUT_SYSTEM && UNITY_2019_3_OR_NEWER
            playerController.Movement.MovingPlatforms.Initialize(playerController, input);
#else
            playerController.Movement.MovingPlatforms.Initialize(playerController);
#endif

This could be fixed by adding null to the Initialize Call or add a default value to PlayerModule.Initialize().

Hertzole commented 4 years ago

Good catch, thanks! It has been fixed.