search

Herzult / php-ssh

An experimental object oriented SSH api in PHP
MIT License
359 stars 82 forks source link

Make RuntimeError based on error code #39

Open nicholasruunu opened 9 years ago

nicholasruunu commented 9 years ago

I made this pull request for a fork of this project: https://github.com/elfet/php-ssh/pull/1

Is this something that would be interesting for this project?

Herzult commented 9 years ago

Interesting input. We must be careful as it changes the subsystem's behavior. My first reaction would be to keep the actual behavior by default and to provide a simple way to activate this output code trick.

nicholasruunu commented 9 years ago

That sounds reasonable.

Sent from my iPhone

On 18 Nov 2014, at 10:38, Antoine Hérault notifications@github.com wrote:

Interesting input. We must be careful as it changes the subsystem's behavior. My first reaction would be to keep the actual behavior by default and to provide a simple way to activate this output code trick.

— Reply to this email directly or view it on GitHub.

dirkluijk commented 9 years ago

What's the status of this issue? I am really interested to have this in Herzult/php-ssh because I am having a problem right now.

After executing npm install via SSH2, an exception is thrown because it assumes an error has occured (which is not the case).