search

Hestat / minerchk

Bash script to Check for malicious Cryptomining
https://laskowski-tech.com/2018/05/07/minerchk-version-1-4-release/
Apache License 2.0
38 stars 11 forks source link

Comment for IPs #1

Closed BBcan177 closed 6 years ago

BBcan177 commented 6 years ago

For minerlist.txt and minerlist-all.txt, would you consider adding a "#" before the IPs?

This would allow for pfBlockerNG to parse these feeds and collect the Domains names and consider the IP as a comment as that format would follow most other domain based feed format.

Would you also consider adding a new IP feed for these IPs?

Also noticed the hostlist.txt has "xmr-eu1[.]nanopool[.]org" but the "minerlist-all" has only "xmr-eu[.]nanopool[.]org"? Was just an observation.

Thanks for providing these Feeds!

ZeroDot1 commented 6 years ago

That's a good idea.

Hestat commented 6 years ago

Thanks for the feedback, I've decided to keep just the minerlist-all for ease of updates. I've added the # commenting for proper parsing. Let me know if you see other improvements or slip ups.

I've added xmr-eu1[.]nanopool[.]org to the minerlist-all as well.