HestiaPi / hestia-touch-one-ui

ONE UI files shown on the touch LCD
GNU General Public License v3.0
5 stars 7 forks source link

Bump Vue CLI to 4.2.3 (#14) #16

Closed jaythomas closed 4 years ago

jaythomas commented 4 years ago

Per the comments about the security vulnerability warnings. The warnings don't apply to how we use those dependencies but it was easy enough to bump the version of Vue CLI we are using, which is what's causing the warning.

➜  yarn why acorn                             
yarn why v1.12.3
[1/4] Why do we have the module "acorn"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "acorn@6.3.0"
info Has been hoisted to "acorn"
info Reasons this module exists
   - Hoisted from "eslint#espree#acorn"
   - Hoisted from "@vue#cli-plugin-babel#webpack#acorn"
   - Hoisted from "eslint-plugin-vue#vue-eslint-parser#espree#acorn"

What I tested: The bundle js file still outputs compatible ES5 javascript for kweb as expected.

What to test: Ensure you can still run yarn build and yarn serve commands. Ensure the app still loads in the browser.