search

HestiaPi / hestia-touch-openhab

OpenHAB2 files for HestiaPi Touch model
GNU General Public License v3.0
60 stars 17 forks source link

The settings Group is unnecessary #18

Closed rkoshak closed 4 years ago

rkoshak commented 4 years ago

I started setting up restoreOnStartup with MapDB to preserve settings between openHAB restarts and I noticed this Group settings whose only use and sole purpose appears to be to let you use a Group element on the sitemap to get a subframe.

You can get the exact same behavior on the sitemap using a Text element without any item=. It's the { } that tells the sitemap renderer that you want to have a subframe.

This PR removes the Group and uses the Text element in it's place.

I've noticed similar odd approaches in some of the code I've reviewed so far learning how it all works together. As I find similar little easy changes I can continue to submit these little PRs or if you prefer I can create an Issue to track them. What ever makes the most sense for your workflow.

Signed-off-by: Rich Koshak rlkoshak@gmail.com

gulliverrr commented 4 years ago

@rkoshak

What ever makes the most sense for your workflow.

As there haven't been (m)any PRs so far, there is no fixed workflow yet. I am also a bit rusty on GitHub on this area so I accidentally closed this issue by merging to the (incorrect) master branch and reverting the commit kept the issue as closed but it should stay open.

gulliverrr commented 4 years ago

Committed to ONE branch.