HestiaPi / hestia-touch-openhab

OpenHAB2 files for HestiaPi Touch model
GNU General Public License v3.0
60 stars 17 forks source link

Boost mode functionality redesign #23

Closed gulliverrr closed 4 years ago

gulliverrr commented 4 years ago

For houses where heating is on AUTO most of the time, Boost makes no sense as it is now. Boost should probably ignore the setpoint and simply run for the selected time. Boost should work for all functions in the same way (heating, cooling, fan, humidity).

rkoshak commented 4 years ago

The fix for this should wait until #26 get's checked in and merged. Once done the fix is really simple and I've already added a TODO comment explaining what and where the changes need to be made.

Essentially, the now merged Boost mode rule needs to call a different lambda instead of the one it currently calls and the lambdas for heating and humidity need to check if we are currently in Boost mode and if so ignore changes in the sensor readings and just keep the device on for the Boost time.