search

HestiaPi / hestia-touch-openhab

OpenHAB2 files for HestiaPi Touch model
GNU General Public License v3.0
62 stars 17 forks source link

While loop missing if Xorg doesn't start #39

Closed raycekar closed 4 years ago

raycekar commented 4 years ago

In reading through the kiosk-xinit.sh script, it seems there should be a while : that encompasses lines 22 to the end of the script. Why I ask is because on line 167, we state Xorg is going to retry but where in the script would it retry? I see the script would terminate at that point.

Line 22 Line 169

Let me know if I am mistakenly missing something

gulliverrr commented 4 years ago

The script does not terminate. It stays in line 158 as the kweb command does not return unless it dies which will wait a bit and continue that while loop from the top again (and again and again). You can test it by killing kweb. Feel free to close the issue if that covers your concern.

raycekar commented 4 years ago

What I am referring to is Line 22 where if that if statement fails and Xorg does not start properly, it goes to Line166 and then echos "Xorg not running. Retrying...", sleeps, and then the scripts stops. At this point I am asking where it would retry at? I there something up the stack that would recall this script to have it retry?

gulliverrr commented 4 years ago

Apologies for missing your point earlier. You are absolutely right. Feel free to submit a PR or I will do it when I get the chance. For your reference the boot sequence is described here. Well spotted! The joy of open source ;)