search

HestiaPi / hestia-touch-openhab

OpenHAB2 files for HestiaPi Touch model
GNU General Public License v3.0
63 stars 17 forks source link

String item value shown as text next to selection #41

Closed gulliverrr closed 4 years ago

gulliverrr commented 4 years ago

Basic UI shows ON/OFF/Boost item value as text next to selection buttons: image I find it redundant as selected button shows status. Removing [%s] from Paper UI>Configuration>Items did not affect Basic UI. This was caused after #38 @rkoshak

rkoshak commented 4 years ago

That's an easy fix. But removing the [%s] isn't enough. This is a long running bug. But you can suppress it using [] instead, though I ended up fixing it in the sitemap. Where do you perfer I apply the fix? The sitemap or on the Item?

gulliverrr commented 4 years ago

I assume the Item is where it should originate correctly although I understand it is a presentation issue only. This is happening for all selection items too (Temperature Unit, System Type and 2nd Stage Heating)

rkoshak commented 4 years ago

After looking at it, I think I want to make the fix on the sitemap instead of on the Item itself. If I make the change to the Item, it breaks the Control tab of PaperUI so you no longer see the state of the mode there.

gulliverrr commented 4 years ago

Fixed by #43