search

Hetarth02 / js-array-helpers

Array Helper functions for your quick use.
MIT License
8 stars 9 forks source link

feature: deep copy of array #hacktoberfest #13

Closed igrzhukovich closed 1 year ago

igrzhukovich commented 1 year ago

function for deep copy of array

Hetarth02 commented 1 year ago

@igrzhukovich I appreciate the PR but the method to create deep copy has some limitations to it. If you could update the function logic that would be much better else if it is too complex for you update the doc comment with the limitations. To know about the limitations of your logic do refer to this article.

igrzhukovich commented 1 year ago

@Hetarth02 Thanks for help. Updated

Hetarth02 commented 1 year ago

@igrzhukovich The code doesn't seem to follow the conventions used in the package. Please assure that it follows the proper code structure to assure there aren't any breaking changes being deployed.

Hetarth02 commented 1 year ago

If you find it difficult, let me know and I will help you if I can.