search

Hetarth02 / js-array-helpers

Array Helper functions for your quick use.
MIT License
8 stars 9 forks source link

Get Random Value #29

Closed MohammadMazin closed 1 year ago

MohammadMazin commented 1 year ago

Returns a random value from the array.

Also caters for edge cases: 1- returns a TypeError using the implemented _throw() function. 2- returns null if length of array is 0.

Hetarth02 commented 1 year ago

Thanks for PR. I have left some feedback regarding the changes.

MohammadMazin commented 1 year ago

@Hetarth02 I'm still new to this, so I wasn't able to find feedback in this PR. But I noticed the change in package.json. Shall I update that and send an updated PR?

Hetarth02 commented 1 year ago

@MohammadMazin Sorry for the late response. But you can check out the feedback here.

And I think there will a file changed section where you can see the feedback too.

MohammadMazin commented 1 year ago

@Hetarth02 Clicking on the link just redirects me to the conversation tab and I can't seem to find anything on the file changed tab either, no comments are visible there. 😅I can try closing this PR and submitting a new one .

Hetarth02 commented 1 year ago

Hmm, that's weird. No problem I will accept the PR. No need for a new one.

Thanks for contributing.👍