🐛 fix optional parameter warning

[wiztigers]

On a fresh Heurist install, database cannot be created due to a PHP deprecation warning.
This blocks database creation on a fresh install of Heurist.

See screenshot below:

(This pull request stems from this issue huma-num/heurist#8)

[wiztigers]

For info, this parse_query function default parameter doesn't seem to be used anywhere in the code ; that's why I took the liberty to remove it (instead of for example providing default values for the last parameters):

$ grep -ri parse_query *
hsapi/dbaccess/compose_sql.php:    $query = parse_query($search_domain, @$params['q'], @$params['s'], @$params['parentquery'], $currUserID);
hsapi/dbaccess/compose_sql.php:function parse_query($search_domain, $text, $sort_order, $parentquery, $currUserID) {
hsapi/dbaccess/compose_sql_new.php:                $query = parse_query($top_query->search_domain, urldecode($this->value), null, null, $top_query->currUserID);

[wiztigers]

For info (bis), as soon as this pull request is merged I'll have to update Heurist Docker image, as the image creation process currenty fixes this (so I'll have to remove the patch).

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information