HewlettPackard / POSH-HPEOneView

PowerShell language bindings library for HPE OneView.
http://hewlettpackard.github.io/POSH-HPEOneView/
125 stars 52 forks source link

ConvertTo-OVPowerShellscript for LIG - Error for VC 100 module #652

Open DungKHoang opened 11 months ago

DungKHoang commented 11 months ago

Expected Behavior

There are several errors in the PowerShell script generated by the cmdlet Convertto-OVPowerShellscript for a LIG with VC 100Gb F32 module

  1. Incorrect Module Type : $fabricModuleType = "SEV100f32" -> Should be SEVC100F32
  2. Missing parameter for the New_OVQosTrafficClass $trafficClass1 = New-OVQosTrafficClass -Name $name -MaxBandwidth $maxBandwidth -BandwidthShare -RealTime:$realTime -EgressDot1pValue $egressDot1pValue -Enabled:$isEnabled
  3. $bandwidthShare = roce --> Should be integer and set to 0 (default value)
  4. $bandwidthShare = fcoe --> Should be integer and set to 0 (default value)
  5. The variable should be an array and NOT integer
    $ingressDot1pClassMapping = 3 $ingressDot1pClassMapping = 5
  6. The variable should be an array and NOT integer
    $ingressDscpClassMapping = ""
  7. Value does not exist in ValidateSet: $QosConfig = New-OVQosConfig -ConfigType CustomWithFCoEWithRoCE -UplinkClassificationType DOT1P_AND_DSCP -UplinkClassificationType DOT1P_AND_DSCP -TrafficClassifiers $trafficClass1, $trafficClass2, $trafficClass3, $trafficClass4, $trafficClass5, $trafficClass6, $trafficClass7, $trafficClass8, $trafficClass9, $trafficClass10
  8. Duplicated parameter in New-OVQsConfig : $QosConfig = New-OVQosConfig -ConfigType "CustomWithFCoE" -UplinkClassificationType DOT1P_AND_DSCP -UplinkClassificationType DOT1P_AND_DSCP -TrafficClassifiers $trafficClass1, $trafficClass2, $trafficClass3, $trafficClass4, $trafficClass5, $trafficClass6, $trafficClass7, $trafficClass8, $trafficClass9, $trafficClass10
  9. With ConfigType of CustomWithFCOE, the number of TrafficClassifiers can only be 6, but the PowerShell script generates 10 $QosConfig = New-OVQosConfig -ConfigType "CustomWithFCoE" -UplinkClassificationType DOT1P_AND_DSCP -UplinkClassificationType DOT1P_AND_DSCP -TrafficClassifiers $trafficClass1, $trafficClass2, $trafficClass3, $trafficClass4, $trafficClass5, $trafficClass6, $trafficClass7, $trafficClass8, $trafficClass9, $trafficClass10

Version Information

HPE OneView PowerShell Library Version (Get-HPOVVersion or $PSLibraryVersion): 8.4 HPE OneView Appliance Version (Get-HPOVVersion -ApplianceVer): 8.4 Output from $PSVersionTable on your Windows Host: 7.3.5

lig.txt