search

HewlettPackard / PacketRusher

High performance 5G UE/gNB Simulator and CP/UP load tester.
Apache License 2.0
116 stars 26 forks source link

Why not to use string instead of int? #124

Open brianchennn opened 6 months ago

brianchennn commented 6 months ago

https://github.com/HewlettPackard/PacketRusher/blob/578563bb2f32925a5178c8f5c17d5ba723c7dd48/config/config.go#L86

I tried to use helm chart to deploy Packet Rusher to Kubernetes Cluster. The type of gnodeb.slicesupportlist.sst in config.yml is string while ue.snssai.sst is integer. This make entrypoint.sh hard to replace ENV variable to integer, can you modify the type to string?

image image

linouxis9 commented 6 months ago

Hi @brianchennn,

I think the rationale to use int instead of string was to enforce that SST was mandatory while SD was not. Though it's stupid (especially since slicesupportlist and snssai should have the same format), and we need a proper configuration validator instead. We indeed need to fix that! By the way, you may also want to take a look at Gradiant's PacketRusher Helm Chart which does not use our entrypoint and instead just generate a config.yml out of a template: https://github.com/Gradiant/5g-charts/tree/main/charts/packetrusher

Cheers, Valentin