search

HewlettPackard / PacketRusher

High performance 5G UE/gNB Simulator and CP/UP load tester.
Apache License 2.0
100 stars 21 forks source link

[FEATURE] Add PacketRusher version as tags #77

Open Borjis131 opened 4 months ago

Borjis131 commented 4 months ago

As the project continues to grow and more features are added, it would be useful to have the possibility to clone specific versions of this software. Adding tags to specific versions could facilitate users to clone this versions.

Also this tags can be setup along with the Releases.

linouxis9 commented 4 months ago

Hi @Borjis131, Thanks for the suggestion. We haven't been doing that for now as we didn't really make our first official release yet. We wanted to tackle #76 / #31 before making our first tag / release, but I'll keep in mind that our users are interested in more frequent tags.

Thanks! Valentin

Borjis131 commented 4 months ago

Thank you, great work @linouxis9!

Borjis131 commented 1 month ago

Hello @linouxis9, I saw that the current PacketRusher version is 1.0.1. So it seems that the release is more or less official now?

I reach to you because I had a problem using the Docker version that is difficult to solve without having the version as tags.

The Docker container needs the gtp5g module installed on the host machine and the Docker version of PacketRusher was using a different compiled version of PacketRusher. So without having the same version on both places, is difficult to check if the versions match or not.

So, please, if the release is official, consider adding the version as a tag and a release. If not, just keep working, you are already doing a great job!

linouxis9 commented 1 month ago

Hi @Borjis131!

I understand your concern and issue! As such, I've created a tag 20240521: https://github.com/HewlettPackard/PacketRusher/releases/tag/20240521

Does it solve your issue for the time being?

Sadly, PacketRusher is not yet ready for a v1.0.0, and I would like for PacketRusher to respect semver principles, so I would like to avoid to release a v1.0.0 for now, and considering the continuous developement cycle (each commit is usually better than the previous one and fix some issues), I feel releasing from time to time v0.a.b do not make too much sense -> main is always the version to use. Or we could tag a version each time we do a commit, à la https://github.com/ggerganov/llama.cpp/releases :D

Actually, PacketRusher has reported itself as being v1.0.1 since its open source release. Does the tag 20240521 work for you (but PacketRusher still reports itself as v1.0.1)? Or would you prefer PacketRusher to output the commit it was built from? We might want to add inside PacketRusher a check for the correct version of gtp5g maybe as well?

Thanks a lot for using PacketRusher, I hope I can help you :-)!

Valentin

Borjis131 commented 1 month ago

Hi @linouxis9, sorry I did not check the version reported by PacketRusher previously and I thought it was something new.

There is no need to create a tag each commit, so no rush, as soon as you start publishing the tags using semantic versioning, I will update the docker project.

Thanks you!