Fix #84 Wrong MCC+MNC encoding

HewlettPackard / PacketRusher

High performance 5G UE/gNB Simulator and CP/UP load tester.

Apache License 2.0

100 stars 21 forks source link

Fix #84 Wrong MCC+MNC encoding #85

Closed linouxis9 closed 4 months ago

linouxis9 commented 4 months ago

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

[X] I have read the CONTRIBUTING document.
[X] Each of my commits messages include Signed-off-by: Author Name <authoremail@example.com> to accept the DCO.

linouxis9 commented 4 months ago

Hi @rjaksa,

Your bug should be fixed by this PR. Can you try PacketRusher again with this fix / using branch fixmnc.

Thanks a lot, Valentin

rjaksa commented 4 months ago

The code change works for the gNB. But there is an informative printf regarding the PLMNs Identities supported by AMF that shows the MNC incorrectly. It lists the 3-digit MNC with the digits in encoded order, instead of the "human readable" format. E.g. MNC 123 is printed as "231".

E.g. for MCC=987, MNC=123, the printf looks like:

INFO[0000] [GNB][AMF] PLMNs Identities Supported by AMF -- mcc: 987 mnc:231

linouxis9 commented 4 months ago

Thank you @rjaksa, it's fixed!