mwilbz commented 5 years ago

Signed-off-by: Matt Wilber mattwilber94@gmail.com

Adds a create_system_users config option, which is True by default, and causes system users to be created upon successful user authentication (existing behavior). When set to False, these system users will not be created.

I did not add myself to the ATTRIBUTION.md document, feel free to add me!

Developer Certificate of Origin Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 660 York Street, Suite 102, San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Matt Wilber mattwilber94@gmail.com

mwilbz commented 5 years ago

Should resolve https://github.com/bluedatainc/jupyterhub-samlauthenticator/issues/27 !

codecov-io commented 5 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.07%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   91.39%   91.47%   +0.07%     
==========================================
  Files           2        2              
  Lines         337      340       +3     
==========================================
+ Hits          308      311       +3     
  Misses         29       29

Impacted Files	Coverage Δ
samlauthenticator/samlauthenticator.py	`91.44% <100%> (+0.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3240ba...ff98481. Read the comment docs.

distortedsignal commented 5 years ago

I'll cut a new version tonight or tomorrow and upload it to PyPI.

HewlettPackard / jupyterhub-samlauthenticator

Add create_system_users config option #29

Codecov Report