Add customization of nameid format paramter in SP metadata

[killerwhile]

This PR allows customisation of nameID format parameter in the metadata file.

Developer Certificate of Origin Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 660 York Street, Suite 102, San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Benoit Perroud

[codecov-io]

Codecov Report

Merging #34 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   91.49%   91.52%   +0.02%     
==========================================
  Files           2        2              
  Lines         341      342       +1     
==========================================
+ Hits          312      313       +1     
  Misses         29       29

Impacted Files	Coverage Δ
samlauthenticator/samlauthenticator.py	91.49% <100%> (+0.02%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2927126...4f6b993. Read the comment docs.

[distortedsignal]

At first glance, this looks great. I'm curious what need this solves, but if you took the time to make such a great PR, I'm not going to question it. I'll work up the documentation changes and I'll try to get a test change in, and we can merge it either today or tomorrow - would that be ok?

[killerwhile]

Thanks for your prompt answer.

I just added some tests as you suggested, I should have done that in the first iteration.

I do agree the real need might be rather opaque, but you know, customer's requirements are opaque, too :)