HewlettPackard / netperf

Netperf is a benchmark that can be used to measure the performance of many different types of networking. It provides tests for both unidirectional throughput, and end-to-end latency.
MIT License
874 stars 187 forks source link

src/nettest_omni.c: fix compilation with GCC10 #48

Closed ffontaine closed 4 years ago

ffontaine commented 4 years ago

GCC10 defaults to -fno-common, which breaks compilation when there are multiple definitions of implicit "extern" variables. Remove the extra definitions.

Fix #42

Signed-off-by: Tony Ambardar itugrok@yahoo.com [Retrieved from: https://github.com/openwrt/packages/blob/master/net/netperf/patches/010-gcc10_multiple_definition_fix.patch] Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

ricera commented 4 years ago

This would also unbreak the compilation on FreeBSD 13.0-CURRENT, too.

ffontaine commented 4 years ago

I'm closing this PR as it's a duplicate of #46