search

HewlettPackard / oneview-golang

Golang bindings for OneView api's
Apache License 2.0
27 stars 21 forks source link

ServerHardware #GetServerHardwareList Issues #103

Closed jsmartt closed 4 years ago

jsmartt commented 7 years ago

In ServerHardware #GetServerHardwareList, I think there are a few issues:

  1. The REST here call doesn't handle errors
  2. This section doesn't appear to do anything useful (does it?). Maybe it was left in after a refactor?
  3. Unmarshalling the data doesn't set the Client property, so many subsequent calls on the objects returned (e.g. PowerOff()) will fail unless you set the Client property manually.
supreethpy commented 5 years ago

115 Issue has been fixed in this PR

VenkateshRavula commented 4 years ago

The fix for this issue is provided in https://github.com/HewlettPackard/oneview-golang/pull/137. Closing this issue now. Feel free to reopen if the issue still exists.