HewlettPackard / oneview-puppet

This project is no longer being developed and has limited support. In the near future this repository will be fully deprecated. Please consider using other OneView projects, such as Terraform and Ansible Collection

https://forge.puppet.com/hewlettpackard/oneview

Apache License 2.0

8 stars 17 forks source link

Fix unit test #113

Closed abiliogp closed 7 years ago

abiliogp commented 7 years ago

Description

Fix unit tests on unexpected scenarios

Issues Resolved

55

Check List

[ ] New functionality includes testing.
- [x] All tests pass ($ rake test).
[ ] New functionality has been documented in the README if applicable.
- [ ] New functionality has been thoroughly documented in the examples (please include helpful comments).
[ ] Changes are documented in the CHANGELOG.

fgbulsoni commented 7 years ago

Is this PR being updated? I still see refactor messages and checking the code it seems like it remains as it was. Main things to look out for are:

unnecessary test declaration inside its, when we are declaring already on let
unecessary mocking
lots of different mocks for find_bys with different inputs always returning the same value
etc.