Extends support of Oneview_uplink_set for API300

HewlettPackard / oneview-puppet

This project is no longer being developed and has limited support. In the near future this repository will be fully deprecated. Please consider using other OneView projects, such as Terraform and Ansible Collection

https://forge.puppet.com/hewlettpackard/oneview

Apache License 2.0

8 stars 17 forks source link

Extends support of Oneview_uplink_set for API300 #60

Closed marikrg closed 7 years ago

marikrg commented 7 years ago

Description

Use Oneview_uplink_set with API 300 on the Synergy and C7000 hardware variants

Issues Resolved

https://github.com/HewlettPackard/oneview-puppet/issues/32

Check List

[x] New functionality includes testing.
- [x] All tests pass ($ rake test).
[x] New functionality has been documented in the README if applicable.
- [x] New functionality has been thoroughly documented in the examples (please include helpful comments).
[ ] Changes are documented in the CHANGELOG.

marikrg commented 7 years ago

I'm fixing the broken build.

marikrg commented 7 years ago

I'm fixing the broken build.

Done.

marikrg commented 7 years ago

line 42: @property_hash[:data] = @data should be @property_hash[:data] = uplink_set.data

Also, found and destroy methods are being inherited and could be dropped.

Done.

marikrg commented 7 years ago

I just noticed that the update is not working properly for Uplink Sets. I will fix it.

marikrg commented 7 years ago

I just noticed that the update is not working properly for Uplink Sets. I will fix it.

As we decided, we are going to fix the update later, since this resource needs a different approach (see the bug opened for oneview-ansible at: https://github.com/HewlettPackard/oneview-ansible/issues/13)