HewlettPackard / oneview-puppet

This project is no longer being developed and has limited support. In the near future this repository will be fully deprecated. Please consider using other OneView projects, such as Terraform and Ansible Collection
https://forge.puppet.com/hewlettpackard/oneview
Apache License 2.0
8 stars 17 forks source link

Reduce code duplication and complexity #82

Closed fgbulsoni closed 7 years ago

fgbulsoni commented 7 years ago

Scenario/Intent

Reduce code duplication and complexity, while maintaining functionality.

Environment Details

-Puppet module for HPE OneView Version: 2.0.0 -OneView SDK Version: 3.1.0 -OneView Appliance Version: 3.0 -OneView Client API Version: 300 -Puppet Version: 4.8 -Ruby Version: 2.2.6 -Platform: Windows

Steps to Reproduce

Check the code, mainly on the resources which currently do not use a parent class.

Expected Result

Should have the least amount of code duplication, as it is possible.

Actual Result

Some classes currently are not yet inheriting from Oneview_resource and thus have a lot of code duplication inside them. Also, others were implemented while the Oneview_resource class was being improved, and could also have many improvements.