HewlettPackard / oneview-puppet

This project is no longer being developed and has limited support. In the near future this repository will be fully deprecated. Please consider using other OneView projects, such as Terraform and Ansible Collection

https://forge.puppet.com/hewlettpackard/oneview

Apache License 2.0

8 stars 17 forks source link

Image Streamer Plan Script support #92

Closed marikrg closed 7 years ago

marikrg commented 7 years ago

Description

Add module for Image Streamer Plan Scripts

Issues Resolved

91

Check List

[x] New functionality includes testing.
- [x] All tests pass ($ rake test).
[x] New functionality has been documented in the README if applicable.
- [x] New functionality has been thoroughly documented in the examples (please include helpful comments).
[x] Changes are documented in the CHANGELOG.

marikrg commented 7 years ago

@fgbulsoni @tmiotto @abiliogp Please, can you review it again?

Since this PR already has a lot of changes, I will leave the CHANGELOG for the next pull request.

marikrg commented 7 years ago

I'm going to change the Notice messages:

Found matching PlanScript Plan Script Puppet (URI: /rest/plan-scripts/83a11251-2f65-495d-aed6-11c339281426) on Oneview Appliance

fgbulsoni commented 7 years ago

Overall changes look good, I think the PR is at the merging point. Last few comments on the readme added and also Changelog should be updated, once that is done this is approved.

fgbulsoni commented 7 years ago

For the changelog, should add something like the following text to the top of the CHANGELOG.md

Unreleased Changes

Suggested release: v2.2.0

Version highlights:

Added support to the Image Streamer REST API version 300 for OS provisioning through OneView.

Puppet Types Added

Image_streamer_plan_script