search

HewlettPackard / oneview-sdk-ruby

This project is no longer being developed and has limited support. In the near future this repository will be fully deprecated. Please consider using other OneView projects, such as Golang and Python.
Apache License 2.0
12 stars 16 forks source link

Method add_uplink for LIG Uplinks Set does not work with Q ports nor integer ports #228

Closed fgbulsoni closed 7 years ago

fgbulsoni commented 7 years ago

Scenario/Intent

When trying to use the lig_uplink_set method to set a Q port or even using the real integer value of the port, the following error is returned: Could not evaluate: Port not supported: Q type not found

Environment Details

Steps to Reproduce

Run the add_uplink method using a Q or integer port. i.e.:

OneviewSDK::LIGUplinkSet.new(@client, name: 'test').add_uplink(3, 'Q1:1')

Expected Result

The port specified is added to the uplink set

Actual Result

It returns errors when both an integer or a Q value port is used.

fgbulsoni commented 7 years ago

This is related and reported by the issue https://github.com/HewlettPackard/oneview-puppet/issues/148

vranystepan commented 7 years ago

Is this related to #216 ? I did not have time to test it yet but it should be possible to get correct port number from /rest/interconnect-types. But such functionality will require ICM model as the parameter ...

fgbulsoni commented 7 years ago

@vranystepan Yep, definitely related. I was just looking into using the Q ports and Integer values though, hadn't crossed my mind using different frames.

vranystepan commented 7 years ago

@fgbulsoni Multiple frames situation is pretty easy. Will try to figure out. Anyway what do you mean with integer values? Do you mean the final relativeValue which can be directly placed to the Logical Interconnect Group data?

fgbulsoni commented 7 years ago

Do you mean the final relativeValue

Yep, I've been asked why it would not work if the correct relativevalue is used instead of a Q or D or whatever port, and it kind of made sense I guess. Definitely not a must and something which may even not be used by users, but again, I've been asked about it.

vranystepan commented 7 years ago

@fgbulsoni I've just put a few notes in the #216

fgbulsoni commented 7 years ago

@fgbulsoni I've just put a few notes in the #216

@vranystepan Looks like great work there, should indeed get rid of all these issues. Great job! :100: :sparkles:

fgbulsoni commented 7 years ago

Closing since this was fixed by #230.