search

HewlettPackard / python-redfish-utility

Python-based utility for interacting with devices supporting a Redfish Service
Other
86 stars 41 forks source link

Flashing v1 FWPKGs without PLDMImage still results in KeyError #90

Closed larsux closed 6 months ago

larsux commented 10 months ago

Hi @rajeevkallur, I just test the new Version 4.5.0.0, but it looks like the issue from #82 still exists:

# ilorest -v flashfwpkg ilo5_210.fwpkg
iLORest : RESTful Interface Tool version 4.5.0.0
Copyright (c) 2014-2023 Hewlett Packard Enterprise Development LP
-------
Local login initiated...
Discovering data...Done
ERROR: 'PLDMImage'
iLORest return code: 255

The erroneous line in the code seems untouched: https://github.com/HewlettPackard/python-redfish-utility/blob/33e5056cccfbcb0cad5ba18c0d6781cb75cea09b/src/extensions/iLO_REPOSITORY_COMMANDS/FwpkgCommand.py#L315

moonrail commented 10 months ago

Still present in 4.6.0.0

rajeevkallur commented 8 months ago

Will be fixed soon. Please recheck in latest build.

larsux commented 8 months ago

Error still exists in latest build (ilorest-4.7.0.0-24.x86_64.rpm):

$ sudo ilorest -v flashfwpkg ilo5_210.fwpkg 
iLORest : RESTful Interface Tool version 4.7.0.0
Copyright (c) 2014-2023 Hewlett Packard Enterprise Development LP
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Local login initiated...
Discovering data...Done
ERROR: 'PLDMImage'
iLORest return code: 255
larsux commented 6 months ago

Bug is fixed in latest version 4.8.0.0

$ sudo ilorest -v flashfwpkg ilo5_210.fwpkg
iLORest : RESTful Interface Tool version 4.8.0.0
Copyright (c) 2014-2024 Hewlett Packard Enterprise Development LP
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Local login initiated...
Discovering data...Done
Uploading firmware: ilo5_210.bin
Successfully checked 'ilo5_210.bin'.
Uploading component ilo5_210.bin
Component ilo5_210.bin uploaded successfully.
...
rajeevkallur commented 6 months ago

Closing.

rajeevkallur commented 6 months ago

Closed