search

HexHive / HexVASAN

16 stars 5 forks source link

Implementation of hashType still does not match paper #1

Closed hal-ler closed 7 years ago

hal-ler commented 7 years ago

This is the second time I had to report it. The first report led to an errata claiming that the code was changed to the correct implementation. This one is better, but it still does not match the paper. Was this ever implemented correctly?

gannimo commented 7 years ago

Thanks for the comment Istvan. Can you be more precise?

hal-ler commented 7 years ago

Look at the pseudo-code in the paper and how it handles recursion. The pseudo-code is the right way to do things. This code is not. Also you still simplify pointer types to a single id.

gannimo commented 7 years ago

Thanks. Feel free to send in a patch.