fix Dockerfile

[vanhauser-thc]

building targets fails because

ARG GROUP_ID 1000
RUN addgroup -g $(GROUP_ID) foo

results in addgroup -g 0 foo instead of 1000 as the ARG cannot be resolved in the system shell. as group id 0 already exists, and error is returned and docker stops building.

ARGs can only be used with docker commands, but are not resolved in the shell (what RUN does). Hence GROUP_ID etc. must be ENV instead.

[adrianherrera]

Thanks! I assume this means you can delete the args from here?

[vanhauser-thc]

What you could do is ignore my pr and do ENV USERID $(USER_ID) And then use $(USERID) in the RUN command and keep the flexibility

[adrianherrera]

Ok that’s a good idea! I’m happy for you to just modify the PR and then I’ll merge :)

On Tue, 28 Mar 2023 at 9:52 pm, van Hauser @.***> wrote:

What you could do is ignore my pr and do ENV USERID $(USER_ID) And then use $(USERID) in the RUN command and keep the flexibility

— Reply to this email directly, view it on GitHub https://github.com/HexHive/magma/pull/141#issuecomment-1486638430, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACB2DEXBVUVWXXHF5KA3MGTW6K7FJANCNFSM6AAAAAAWKKCYNQ . You are receiving this because you commented.Message ID: @.***>

[vanhauser-thc]

done, I fixed another bug in the Dockerfile as well.

btw. I will send another PR that will optimize the afl++ which far from optimal plus cannot be easily updated to newer versions

[vanhauser-thc]

from my side this can be merged. it is working for my locally.