HexHive / retrowrite-dev

Retrowrite Development (Internal) Repository
7 stars 2 forks source link

Add a dockerfile for simpler environment management #6

Closed louismerlin closed 2 years ago

louismerlin commented 3 years ago

The goal of this PR is to replace the venv setup by a docker setup to be able to run retrowrite on many environments with minimal setup.

I have only tested the new environment with the demos/user_demo, and also created a one-line script to build cftool.

Still TODO :

cyanpencil commented 3 years ago

The docker for buidling cftool is especially nice, thanks!

diagprov commented 3 years ago

Question on this now I'm looking at it - do we need the capstone submodule? I can't remember if we build it ourselves or if that is my other project...

louismerlin commented 3 years ago

From what I could gather, it was added as a third party module to make sure the latest version was used, even with an older OS. Docker removes this problem, so I deleted the third party module. I could be wrong, but that was how it was stated in the documentation.

cyanpencil commented 3 years ago

So I gave another look at this and I have the following comments:

Sorry for the late review ^^

louismerlin commented 3 years ago

@cyanpencil commits 4a7ed1f and 68da347 address your concerns.

@diagprov maybe we can discuss trying out this branch on arm on Wednesday ?

cyanpencil commented 3 years ago

Thanks a lot! Looks good to me now :)

diagprov commented 2 years ago

Gonna close this, I think we functionally merged it, and now the tool is public anyway we can continue development there. 2x issue trackers is a mess :)