HexaVault / AD-breaketernity

MIT License
4 stars 13 forks source link

Galaxy Generator error during its final stage with infinite cap #24

Closed James103 closed 2 weeks ago

James103 commented 1 month ago

Describe the bug When the Galaxy Generator reaches its final stage, where the number of Galaxies it can generate is effectively infinite, it errors out with the following error, causing it to not render anymore:

01:19:50.492 TypeError: "mag" is read-only
    roundExpTo ad-notations.esm.js:19
    formatLDecimal ad-notations.esm.js:118
    format format.js:16
    format ui.js:55
    render PelleGalaxyGeneratorPanel.vue:81
    VueJS 14
    update ModernSidebar.vue:23
    dispatch event-hub.js:26
    flushEvents ui.js:143
    promise callback*dispatch ui.js:130
    dispatch event-hub.js:32
    gameLoop game.js:437
    gameLoop intervals.js:56
    setInterval handler*start intervals.js:11
    restart intervals.js:25
    restart intervals.js:53
    postLoadStuff storage.js:569
    loadPlayerObject storage.js:549
    import storage.js:167
    importSave ImportSaveModal.vue:135
    VueJS 3
vue.runtime.esm.js:3065
    VueJS 17
    update ModernSidebar.vue:23
    dispatch event-hub.js:26
    flushEvents ui.js:143
    (Async: promise callback)
    dispatch ui.js:130
    dispatch event-hub.js:32
    gameLoop game.js:437
    gameLoop intervals.js:56
    (Async: setInterval handler)
    start intervals.js:11
    restart intervals.js:25
    restart intervals.js:53
    postLoadStuff storage.js:569
    loadPlayerObject storage.js:549
    import storage.js:167
    importSave ImportSaveModal.vue:135
    VueJS 3

To Reproduce Unlock the Galaxy Generator, then use it to drain all Rifts. Once the last rift is drained, the generated galaxy cap vanishes, producing the above error.

Expected behavior The Galaxy Generator should not throw an error.

Screenshots image

Savefile save2.txt

HexaVault commented 1 month ago

seems to be a bug with formatting code itself, so will have a look after ive sorted be port (also i think the issue here is im trying to format what should infinite galaxies, which is a bug in of itself)

HexaVault commented 1 month ago

hopefully fixed, not gonna close incase still broken

James103 commented 2 weeks ago

I can no longer reproduce this error; it appears to be fixed.