search

HexagonMC / BungeeCord

BungeeCord for Minecraft 1.7.10/1.8/1.9/1.10/1.11/1.12/1.13/1.14/1.15/1.16/1.17/1.18/1.19
Other
157 stars 66 forks source link

1.17.1 #294

Closed MedicOP closed 3 years ago

spannerman79 commented 3 years ago

Have you verified that Forge 1.7.10 has no issues? Otherwise there will be a repeat of https://github.com/HexagonMC/BungeeCord/issues/152 (plus others that I'm not going to go digging for)

MedicOP commented 3 years ago

i did not

spannerman79 commented 3 years ago

Until then - this PR should be a draft.

MedicOP commented 3 years ago

I just merged changes from upstream, don't see why it would break anything

spannerman79 commented 3 years ago

Well it is obvious that you didn't even bother to read/check the linked issue for you to make that comment.

MedicOP commented 3 years ago

I did and I don't see how this commit would break anything. Since you seem to know so much about this issue from 3 years ago, why don't you go check it yourself then?

spannerman79 commented 3 years ago

Well you see, if in fact it was my PR I would have before pushing it from a draft to a full PR.

Stop deflecting.

MedicOP commented 3 years ago

It's up to the repository owner whether he wants to merge this PR or not.

The issue is irrelevant to me and I'm not going to bother setting up a whole Forge 1.7.10 server and client just to test it.

If the developer doesn't want this PR then he can simply close it, so simple.

I'm using this on my own production server with 100+ players with no issues.

Didn't expect so much shit for contributing a PR out of the kindness of my own heart, could have easily kept this to myself while others wait for the actual developer to update to 1.17.1.

Dickhead

spannerman79 commented 3 years ago

The issue is irrelevant to me and I'm not going to bother setting up a whole Forge 1.7.10 server and client just to test it.

https://github.com/HexagonMC/BungeeCord/blob/master/README.md#L9

Didn't expect so much shit for contributing a PR out of the kindness of my own heart, could have easily kept this to myself while others wait for the actual developer to update to 1.17.1.

A contribution assumes that you have done due dillagace and tested any changes which may confict with the repo's purpose. For which I have already shown a single line from README.md.

Dickhead

Shows how little you do your own checking on what this particular fork is ment for.

johnfriedrich commented 3 years ago

Hello, thanks for your work, however I prefer to do the merge myself. In case of issues it's easier for me to locate where they could be or what have caused them

MedicOP commented 3 years ago

@spannerman79 Actual developer's PR and mine ended up being exactly the same. Thanks for nothing.