HexagonNico / UndergroundJungle

A Minecraft Mod that adds an underground jungle biome and an underground jungle temple
Other
3 stars 4 forks source link

[Bug]: Still overground biome - Fabric 1.20.1 #10

Closed xR4YM0ND closed 9 months ago

xR4YM0ND commented 9 months ago

Same as https://github.com/HexagonNico/UndergroundJungle/issues/4

Description

Most of the time the caves work, but sometimes they reach till the top.

2023-12-31_17 49 20

2023-12-31_17 49 37

Deepest spot y 73

HexagonNico commented 9 months ago

Update on this problem:

I think this may be a problem on TerraBlender's end, because even if I increase the Depth parameter the biome still generates above ground. I've found it is mentioned in this issue, but they're saying it is caused by parameters not being set correctly. Vanilla cave biomes have a Depth value of (0.2, 0.9), which is the same I use for the underground jungle and it works fine without TerraBlender.

I've found that if instead of adding the underground jungle as a new biome I replace the lush cave in the region then it will generate underground. Although this isn't ideal because it doesn't give much control over where the biome generates, I think this is what I will do for the next update.

xR4YM0ND commented 9 months ago

Maybe take a look how the mod Profundis manages this Or other cave biome mods

HexagonNico commented 9 months ago

Fixed by d91e9a722265dfd7d3a303483e40dd3a8bd26fd4

The underground jungle biome now replaces the Lush Cave in Underground Jungle regions.