search

Hexaoxide / Carbon

Carbon is a modern chat plugin built on channels, with just about every single setting and format configurable.
https://modrinth.com/mod/carbon
GNU General Public License v3.0
131 stars 39 forks source link

[Bug] "Exceeded character limit" broken. #504

Closed ZepsiZola closed 4 months ago

ZepsiZola commented 4 months ago

Bug Description:

What is not working as it should?

Plugin says the nickname exceeds character limit when it should not.

image

Steps to reproduce:

  1. Install Carbon, Vault, and LuckPerms
  2. Give non-op player carbonchat.nickname.set, carbon.nickname.tags.color, carbon.nickname.tags.gradient
  3. Have player type the command /nick<gradient:000000:FFFFFF>TestName
  4. Plugin says that the name exceeds the character limit.

System Details:

  1. Server Type: Folia
  2. Server Software: Folia version git-Folia-"ef2c697" (MC: 1.20.4)
  3. MC Version: 1.206
  4. Carbon Version: 3.0.0-SNAPSHOT+4670b57

Pastebins:

Any other relevant details:

jpenilla commented 4 months ago

The provided nickname is not valid MiniMessage. So the entire content has its length checked. If the gradient tag was valid only "TestName" would count.

See https://webui.advntr.dev/, https://docs.advntr.dev/minimessage/

Screenshot 2024-06-22 at 5 08 27 PM