search

Hexastack / eazychart

EazyChart is a reactive chart library 📈, it allows you to easily add SVG charts in your React and Vue web applications.
https://eazychart.com
MIT License
23 stars 14 forks source link

🐛 [BUG] - @eazychart-[vue]- missing global dependency package @vue/cli #36

Closed AlanLes closed 2 years ago

AlanLes commented 2 years ago

Description

When one wants to run vue-tests, one needs to have @vue/cli installed globally.

Reproduction steps

Given having no @vue/cli installed globally try to:

  1. Go to cd packages/ez-vue
  2. Run yarn test or npm run test

The result is 

> eazychart-vue@0.1.16-alpha.0 test
> vue-cli-service test:unit

sh: vue-cli-service: command not found

Screenshots

image

Browsers

No response

OS

Mac

marrouchi commented 2 years ago

@AlanLes I think we should probably add a line in the readme file, under the "Contribute" section to state that one needs to install it globally. Or we should add it as a dev dependency for the package "ez-vue". WDYT ?

AlanLes commented 2 years ago

I guess we shouldn't obligate anybody to install packages globally; therefore, I'm 100% for the alternative of adding additional devDependency for the package ez-vue :)

marrouchi commented 2 years ago

@AlanLes vue cli appears to be already in the devDependencies, https://github.com/Hexastack/eazychart/blob/79428948bcffd02bb6d1710f5cefa94291de4006/packages/ez-vue/package.json#L78

Could it be that happened because you didn't run yarn setup ?

AlanLes commented 2 years ago

Yep, I guess it must be that. I believe we may close this Issue already. 😇