search

HexedHero / CitizensCMD

Add-on for Citizens that adds click commands to NPC's
https://www.spigotmc.org/resources/30224/
GNU General Public License v3.0
9 stars 5 forks source link

Stop using EventPriority.MONITOR #13

Closed Real6dq closed 1 year ago

Real6dq commented 1 year ago

image Please, remove the monitor from every single listener. Replace it with anything else, asap, this will crash the hell out of your server, a new crashing method. Monitor cannot be cancelled, so no point of the ignoreCancelled.

HexedHero commented 1 year ago

Monitor cannot be cancelled, so no point of the ignoreCancelled.

That is not how Montior works. It looks like your crash is from a player spamming /pv which is not from CitizensCMD and would happen just by spamming the command (Unless you have command spam protection) which you'll need to add a cooldown on the NPC.