search

Hexeption / AEInfinityBooster

https://www.curseforge.com/minecraft/mc-mods/aeinfinitybooster
GNU Lesser General Public License v3.0
4 stars 14 forks source link

Don't log the creation of the creative tab at listener registration #19

Closed SirEndii closed 3 months ago

SirEndii commented 9 months ago

Before, when forge tried to add an RegisterEvent, it would call addListener. But since addListener((RegisterEvent event)... can be called for multiple register event types, it would log the message also multiple times. image

I moved the logging to the actual place where the creative tab registers itself

rshchekotov commented 9 months ago

Hey @SirEndii

Thanks for taking the initiative and creating the MR! (Coming from #16)

Would you consider lowering the log level to debug and adding the stringified version of the translatable component into the log message as well? In my humble opinion that would increase the value of the log message immensely.

Other than that - what you did seems to make sense to me )).

Looking forward to your opinion on this and thanks again!

Cheers, Roman.

SirEndii commented 9 months ago

Yeah, you're right @rshchekotov

I will add the ID to the message and set the level to debug

SirEndii commented 9 months ago

image

It now prints the message with the actual ID of the creative mode tab as a debug message

Zelioth commented 4 months ago

You claim to of fixed this but did you not post a fixed version for 1.20.1 on forge? Still getting tons of log spam for AEINFINITYBOOSTER CREATIVE MODE TAB

Zelioth commented 4 months ago

image

rshchekotov commented 4 months ago

image

Hey @Zelioth,

you can see at the top of this issue that it states 'Open' - this means that it has not been 'Merged' yet into the codebase and is thus not integrated yet.

We, as "contributors" did the best we could by providing the mod author with the changes and thus on our end it's "fixed". The problem is that this won't yet be available for the general consumer until the mod author decides to merge this issue. We, by that I mean the person who wrote the code @SirEndii and myself who skimmed over the written code, do not have the privileges to merge this into the product that gets released on say, CurseForge or Modrinth.

The only people who can do so are those listed as contributors on the Repository page.

Cheers, Roman

SirEndii commented 3 months ago

Is there a particular reason why you've closed this

Hexeption commented 3 months ago

Is there a particular reason why you've closed this

Was fixed in latest update