Hexlet / hexlet-correction

Typo Reporter
https://fixit.hexlet.io/
GNU Affero General Public License v3.0
51 stars 83 forks source link

Bug: When trying to log in to a account with an invalid password, no error appears #295

Open Alena007S opened 3 months ago

Alena007S commented 3 months ago

Summary

When trying to log in to a account with an invalid password, no error appears. This issue is about CORS error on widget

Reproduction steps

1. open the login page https://hexlet-correction.herokuapp.com/login?error
2. Enter the correct Email
3. Enter incorrect Password
4. Press Login button

Expected result

Login was not successful. The message "Bad credentials" appears

Actual result

Login was not successful. But the message error does not appear 147

Browsers

Chrome

OS

Windows

sergi-Jr commented 1 month ago

Hi. Actually the “bad credential” image page gets in, but because “invalid-feedback” is applied strangely on the form there is no display (I'm not good at bootstrap css, but it seems to be the case). I suggest not to remake the login page under invalid-feedback, but to return a working bootstrap alert message in the danger style. Especially this error indicates novalid password OR/AND email, so I think this would be a good solution. It will look like this image

What do you think?

Ovsenka commented 1 month ago

Hi. Actually the “bad credential” image page gets in, but because “invalid-feedback” is applied strangely on the form there is no display (I'm not good at bootstrap css, but it seems to be the case). I suggest not to remake the login page under invalid-feedback, but to return a working bootstrap alert message in the danger style. Especially this error indicates novalid password OR/AND email, so I think this would be a good solution. It will look like this image

What do you think?

Ok, looks good, i'll try fix it