Closed lovestaco closed 1 year ago
After every documentation change - we are supposed to run the following and commit all resultant files:
mkdocs:
cd docs/Lama2; ./build.sh
Anyway - wait till my overall review finishes, then you can do this.
Remaining comments - I think we still do not have functionality for obtaining the variable suggestions from VSCode (using some CLI switch - pls make proposals). That can be added to this MR itself.
In general - nice first MR :+1:
Also - we must add test case(s) for this new logic.
L2 can now fetch variables declared in l2config.env which can be in the parent directory.
L2 will first fetch the variables from the l2config.env which can be in the parent directory and
then fetch the variables from l2.env from the present dir.
The description has to be more precise.
l2config.env
is searched for, from the present directory to all its ancestors (upto /
). Yes, a directory may have both l2.env
AND l2config.env
(make sure this is so)Also - we must add test case(s) for this new logic.
This has not been addressed @lovestaco
Also - we must add test case(s) for this new logic.
This has not been addressed @lovestaco
What type of MR is this?
Description
This MR adds the feature of supporting global variables. Edit1:
L2 can now fetch variables declared in
l2config.env
which can be in the parent directory.l2config.env
is searched for, from the present directory to all its ancestors (upto/
).A directory may have both
l2.env
ANDl2config.env
Edit2:
l2 --env <l2FilePath>
.Important code file to start Code Review from
controller.go
Added tests?
Added to documentation?