search

HexoCraft / AddLight

This plugin allow server admin to add invisible light sources
https://dev.bukkit.org/projects/addlight
3 stars 6 forks source link

Light sources being removed #16

Closed LogGits closed 5 years ago

LogGits commented 6 years ago

I have been noticing light sources have been disappearing. Any idea why light sources could be removed upon restart?

DoreK333 commented 6 years ago

At me, the light source started to disappear after re-entering the server :(

LogGits commented 6 years ago

Yeah im having the same issue.

hexosse commented 6 years ago

That's actually a problem whenever you have random-light-updates: true in your spigot.yml. I'm trying to find a workaround with no luck for the moment.

In fact, I could store any lights position and restore them using the same process as spigot does with random lights update. However, I think this is not a good solution as I don't want to store any lights positions.

Working on it, stay tuned ...

LogGits commented 6 years ago

@hexosse Just a heads up my random-light-updates is set to false and i still get this issue.

DoreK333 commented 6 years ago

@LogGits me too ;)

hexosse commented 6 years ago

@LogGits @DoreK333 Are you are using FastAsyncWorldedit ?

DoreK333 commented 6 years ago

No.

LogGits commented 6 years ago

@hexosse yes I am, and I am also using PaperSpigot

LogGits commented 6 years ago

@DoreK333 Are you using PaperSpigot aswell?

DoreK333 commented 6 years ago

yes ;)

Cryptite commented 6 years ago

As I understand it, Paper recently removed random-light-updates as a thing. They will always update lightmaps now.

Creating a light inherently does an update on the Chunk, which then automatically flags it to have a light-update; so we're in need of a new method for keeping lights lit.

DoreK333 commented 6 years ago

Can I find out when it will be fixed?

Cryptite commented 6 years ago

@hexosse Any luck on this?

hexosse commented 6 years ago

Not yet. Working on it

LogGits commented 6 years ago

@hexosse is there an event that you can hook into like a LightUpdateEvent or something like that? If not maybe he paperspigot team could implement such a feature upon request?

hexosse commented 6 years ago

There is no message like that. Lights depend on the mechanics of each block type. AddLights, change this data but it seems to be reset some way?

LogGits commented 6 years ago

@hexosse could this potentially fix this issue? https://ci.destroystokyo.com/job/PaperSpigot/1275/changes It is a recent update.

DoreK333 commented 6 years ago

I checked and now everything works as it should