HextechDocs / lcu-explorer

rift-explorer replacement from the original contributors
137 stars 9 forks source link

Scroll performance is absolutely miserable #9

Open ciriousjoker opened 2 years ago

ciriousjoker commented 2 years ago

When I open the plugins tag, it takes around 2 mins to load the list and whenever I scroll, it takes 10 seconds to "apply" the new scroll offset. Sadly, it's completely unusable because of it.

A virtual scroller seems to be necessary here.

That being said, if you don't expand the plugin section it's usable.

shaun-wild commented 2 years ago

Performance in general is extremely poor, this app is next to unusable for me.

ciriousjoker commented 2 years ago

I believe chrome supports the element by now. Perhaps this can be an easy 2 line fix.

Edit: Nevermind that thing has been abandoned.

Theresare simple J's libraries for that though. It doesn't even need to look fancy or support accurate scrollbars, being usable is totally enough.

JustArion commented 1 year ago

The performance has been greatly improved to being functional to use, though sadly I get an error while trying to build the project.

[nextron] Clearing previous builds
[nextron] Building renderer process
info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
Failed to compile.

./layouts/main/index.tsx:7:23
Type error: Cannot find module '@state/Theme' or its corresponding type declarations.

   5 |
   6 | import Header from "@components/Titlebar";
>  7 | import ThemeAtom from "@state/Theme";
     |                       ^
   8 |
   9 | import Styled from "./assets/styled";
  10 |
info  - Checking validity of types .

Though yarn dev works fine and allows us to see the performance improvements.

Please publish a release or fix the build error.

bayu01 commented 1 year ago

I would love a rewrite of this plugin. pretty please n_n Even with all the slowness it works great for exploratory purposes.