search

Hextris / hextris

Fast paced HTML5 puzzle game inspired by Tetris!
https://hextris.io
Other
2.22k stars 971 forks source link

Color blind mode #87

Closed DnlRKorn closed 10 years ago

DnlRKorn commented 10 years ago

This is a very basic implementation of a color blind system, I added a simple button under play (that doesn't fade). I'll definitely work on this more later if you guys would like, but here's a very basic outline of the system.

garrettdreyfus commented 10 years ago

Hey thanks man! This is awesome! I'll get to work and try to make the button the way we do the other stuff. Thanks for the help!

P.S. This may sound silly, but what would it be politically correct to say "If you are colorblind , these alternate colors may help you out!"?

DnlRKorn commented 10 years ago

What you said sounds pretty good, but if want something different, maybe "A mode without red and green"

DnlRKorn commented 10 years ago

Do you want me to rework the button so it changes it on, and then if you press it again it will turn it off (I'd imagine having this work with a background color change would be pretty simple, but I'm not really an expert in CSS)

lengstrom commented 10 years ago

I think that to use this mode effectively, we'd have to make a dict wherever we use colors (most specifically checking.js) that would translate normal hextris colors into colorblind friendly mode hextris colors so that previous saves don't get messed up (ie, having previous colors in place that can't be destroyed, as those colors aren't dropping anymore)

garrettdreyfus commented 10 years ago

Checking will be fine if we just iterate through blocks and change block.color to the correct colorblind equivalent

On Mon, Aug 18, 2014 at 1:55 PM, Logan Engstrom notifications@github.com wrote:

I think that to use this mode effectively, we'd have to make a dict wherever we use colors (most specifically checking.js) that would translate normal hextris colors into colorblind friendly mode hextris colors so that previous saves don't get messed up (ie, having previous colors in place that can't be destroyed, as those colors aren't dropping anymore)

— Reply to this email directly or view it on GitHub https://github.com/Hextris/hextris/pull/87#issuecomment-52529494.

lengstrom commented 10 years ago

Right, yeah, that’s what I meant that we should do. Do you know whether we still have weird hex conversion issues? I remember sometimes in old versions we’d have rgb() values inexplicably converted to hex colors.

On Aug 18, 2014, at 1:57 PM, Garrett Finucane notifications@github.com wrote:

Checking will be fine if we just iterate through blocks and change block.color to the correct colorblind equivalent

On Mon, Aug 18, 2014 at 1:55 PM, Logan Engstrom notifications@github.com wrote:

I think that to use this mode effectively, we'd have to make a dict wherever we use colors (most specifically checking.js) that would translate normal hextris colors into colorblind friendly mode hextris colors so that previous saves don't get messed up (ie, having previous colors in place that can't be destroyed, as those colors aren't dropping anymore)

— Reply to this email directly or view it on GitHub https://github.com/Hextris/hextris/pull/87#issuecomment-52529494.

— Reply to this email directly or view it on GitHub.

garrettdreyfus commented 10 years ago

Lol that was trippy. Im not sure haven't looked at that code in ages.

On Mon, Aug 18, 2014 at 2:02 PM, Logan Engstrom notifications@github.com wrote:

Right, yeah, that’s what I meant that we should do. Do you know whether we still have weird hex conversion issues? I remember sometimes in old versions we’d have rgb() values inexplicably converted to hex colors.

On Aug 18, 2014, at 1:57 PM, Garrett Finucane notifications@github.com wrote:

Checking will be fine if we just iterate through blocks and change block.color to the correct colorblind equivalent

On Mon, Aug 18, 2014 at 1:55 PM, Logan Engstrom < notifications@github.com> wrote:

I think that to use this mode effectively, we'd have to make a dict wherever we use colors (most specifically checking.js) that would translate normal hextris colors into colorblind friendly mode hextris colors so that previous saves don't get messed up (ie, having previous colors in place that can't be destroyed, as those colors aren't dropping anymore)

— Reply to this email directly or view it on GitHub https://github.com/Hextris/hextris/pull/87#issuecomment-52529494.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/Hextris/hextris/pull/87#issuecomment-52530497.