Remove awt.Rectangle

[killpackoff]

Please remove the java.awt.Rectangle to use the library on Android

[adam-arold]

Good idea, thanks for the PR. Where does this Rectangle come from? Did you copy it from somewhere or is this a custom implementation? I'm asking because if you just copied it from a well-established library there can be licensing issues.

[killpackoff]

it's from my arsenal. But I do not remember maybe there are parts from other libraries in it, it's better not to miss it. For me, Rectangle are not useful. I'm thinking you could take a trivial implementation without methods just a container or copy methods from the awt.Rectangle. if you need them.

[adam-arold]

Yep you are right. We don't need Rectangle, just the intersects and the contains methods. Do you have some unit tests for this class?

[killpackoff]

there are no tests for this class.

[adam-arold]

Can you add some tests to cover the functionality used by Hexameter? You can look at an example here.

[killpackoff]

I wrote the tests. Do I need to make another PR?

[killpackoff]

but these tests are in JUnit. I do not know Kotlin

[adam-arold]

Thanks, this will be fine. Can you revert build.gradle to its original state? Some lines were removed for some reason.

[killpackoff]

Of course. sorry, inadvertently missed

[adam-arold]

Cool I merged it! Can you use jitpack to pull the new version if I create a tag? I can't do a proper release right now.

[killpackoff]

yes of course, just tell me the version number

[adam-arold]

okay, I'll create a tag soon, I'll let you know when it is ready

[adam-arold]

Try it with 2017.1.1-SNAPSHOT.

[killpackoff]

Thanks, I used the tag and it works. Now on android =)

[adam-arold]

Good to hear! Feel free to come up to our Discord channel if you have questions!