Closed killpackoff closed 6 years ago
Good idea, thanks for the PR. Where does this Rectangle
come from? Did you copy it from somewhere or is this a custom implementation? I'm asking because if you just copied it from a well-established library there can be licensing issues.
it's from my arsenal. But I do not remember maybe there are parts from other libraries in it, it's better not to miss it. For me, Rectangle are not useful. I'm thinking you could take a trivial implementation without methods just a container or copy methods from the awt.Rectangle. if you need them.
Yep you are right. We don't need Rectangle
, just the intersects
and the contains
methods. Do you have some unit tests for this class?
there are no tests for this class.
Can you add some tests to cover the functionality used by Hexameter? You can look at an example here.
I wrote the tests. Do I need to make another PR?
but these tests are in JUnit. I do not know Kotlin
Thanks, this will be fine. Can you revert build.gradle
to its original state? Some lines were removed for some reason.
Of course. sorry, inadvertently missed
Cool I merged it! Can you use jitpack to pull the new version if I create a tag? I can't do a proper release right now.
yes of course, just tell me the version number
okay, I'll create a tag soon, I'll let you know when it is ready
Try it with 2017.1.1-SNAPSHOT
.
Thanks, I used the tag and it works. Now on android =)
Good to hear! Feel free to come up to our Discord channel if you have questions!
Please remove the java.awt.Rectangle to use the library on Android