Rename Boolean fields to provide standard isXXX getter

Hexworks / mixite

A GUI agnostic hexagonal grid library. Supports a multitude of grid layouts including hexagonal, triangular, rectangular and more.

Apache License 2.0

191 stars 31 forks source link

Rename Boolean fields to provide standard isXXX getter #46

Closed drekbour closed 4 years ago

drekbour commented 4 years ago

Rename resolving #42. I have a bunch of changes I would like to make (*) so am testing to see if PRs are accepted : )

(*) I actually did many refactorings years ago against hexameter but didn't share.

adam-arold commented 4 years ago

Hey, @drekbour I completely forgot about that issue! Thanks for fixing this! 🎉 What other changes do you have in mind? (you can merge this one)

drekbour commented 4 years ago

perf items and further generalisations (notably not requiring SatelliteData at all). I'll add to this 'using kotlin' (which is why I want a java sample so I don't unknowingly break the api). I'll try to group these up and PR sequentially. First up is figuring out how to write a JMH test in kotlin+gradle.

adam-arold commented 4 years ago

What's a JMH test?

drekbour commented 4 years ago

http://tutorials.jenkov.com/java-performance/jmh.html

adam-arold commented 4 years ago

Hah, never tried it so far! Sounds interesting. So I approved this PR, you can merge it if you want!

drekbour commented 4 years ago

I don't have a merge option anywhere.

adam-arold commented 4 years ago

Weird. I merged it though!