search

Hexxeh / rpi-firmware

Firmware files for the Raspberry Pi
Other
775 stars 207 forks source link

initramfs generation by checking /etc/default/raspberrypi-kernel #200

Closed dsx724 closed 5 years ago

dsx724 commented 5 years ago

There's a INITRD=Yes field in /etc/default/raspberrypi-kernel. Is it possible to run the initramfs generation if this is set?

XECDesign commented 5 years ago

The long term plan is to add an initramfs-tools fork that works with the raspberry pi kernel. You can add your own hooks in the meantime.

dsx724 commented 5 years ago

If a user calls rpi-update, it doesn't call update-initramfs to the best of our knowledge. The machines will break on next boot since it is missing the modules that were included in initramfs.

dsx724 commented 5 years ago

@XECDesign Sorry I filed this ticket on the wrong repo. It was suppose to be in the rpi-update repo. https://github.com/Hexxeh/rpi-update/issues/252

Any chance you can add a call there if you have access to that repo?

XECDesign commented 5 years ago

Sorry I filed this ticket on the wrong repo.

No worries, I actually thought I was looking at a different repo when I saw this report as well, so we were both approaching it from different directions.

Any chance you can add a call there if you have access to that repo?

I do not.

popcornmix commented 5 years ago

Are you saying it is enough to call update-initramfs after the kernel has been updated by rpi-update? And this is safe to do for non-initramfs users?

dsx724 commented 5 years ago

@popcornmix

I added a trigger that checks /etc/default/raspberrypi-kernel to see if INITRD is set to be generated.

https://github.com/dsx724/rpi-update/commit/9a6add6f65509e50acf60fc2e9582d685f538f05

I also added a script rpi-initramfs-config to update config.txt.

https://github.com/dsx724/rpi-update/commit/b6c495e724b34af0a67963f0b61013840823ef73

I will probably have to also add initramfs cleanup to only keep the initramfs for the active kernel. Although I do wish RPI_INITRD was implemented so that we can not have these scripts to make up for the deficiency.

dsx724 commented 5 years ago

I added pruning old initrd files as well to prevent the FAT partition from blowing up: https://github.com/dsx724/rpi-update/commit/3e9b44d607793b061ea32c647f69c50dc559e5a3

lurch commented 5 years ago

@dsx724 I think if you have changes you want to get into rpi-update, then you'll need to submit a PR to https://github.com/Hexxeh/rpi-update/pulls rather than posting commit-links to an issue on https://github.com/Hexxeh/rpi-firmware :wink:

@popcornmix I think this can be closed as a duplicate of https://github.com/Hexxeh/rpi-update/issues/252

popcornmix commented 5 years ago

Okay, continue discussion in https://github.com/Hexxeh/rpi-update/issues/252 (or submit a PR).