Soften Pi4 check_partition for use in directory destination

Hexxeh / rpi-update

An easier way to update the firmware of your Raspberry Pi

MIT License

1.94k stars 232 forks source link

Soften Pi4 check_partition for use in directory destination #281

Closed macmpi closed 3 years ago

macmpi commented 5 years ago

ref https://github.com/Hexxeh/rpi-update/commit/882f5c188dce31365885c8ff23724749294bf8c1

check_partition addition is causing issues on usecases where rpi-update is used to build distributions: in such case destination may be a simple directory rather than a partition per say. Could this check be done in a "softer" manner, to play nice with such usecases?

Would be nice if WANT_PI4 usage is explained in README.md expert options too. Thanks for consideration.

volumio commented 5 years ago

Made a pull request: https://github.com/Hexxeh/rpi-update/pull/282

Ruffio commented 3 years ago

@popcornmix what is status on this?

Ruffio commented 3 years ago

@macmpi isn't this scenario covered by the merge of #283 ? Can this be closed?

Ruffio commented 3 years ago

@macmpi can this issue be closed?

macmpi commented 3 years ago

sure, thanks.