search

HeyAnirudh / Certificate-Generator

Making certificates is a tiresome job , lets automate it with python and opencv!!
3 stars 6 forks source link

use OS modue to remove hard coded paths to files #7

Open Beatrix-droid opened 2 years ago

Beatrix-droid commented 2 years ago

currently the application has hard coded values to paths of files: 'C:\Users\Admin\Desktop\github\certificates_streamlit\pics\apricus.png') and "images\img.png")

the problem is that they are hard coded for a particular windows machine. Use the OS module to remove the hard coded values, and provide a layer of abstraction so that the application also works on other operating systems

HeyAnirudh commented 2 years ago

currently the application has hard coded values to paths of files: 'C:\Users\Admin\Desktop\github\certificates_streamlit\pics\apricus.png') and "images\img.png")

the problem is that they are hard coded for a particular windows machine. Use the OS module to remove the hard-coded values, and provide a layer of abstraction so that the application also works on other operating systems

hey @Beatrix-droid I have given a proper format to create an issue on discord, please check and follow the same.

Beatrix-droid commented 2 years ago

currently the application has hard coded values to paths of files: 'C:\Users\Admin\Desktop\github\certificates_streamlit\pics\apricus.png') and "images\img.png")

the problem is that they are hard coded for a particular windows machine. Use the OS module to remove the hard-coded values, and provide a layer of abstraction so that the application also works on other operating systems

hey @Beatrix-droid I have given a proper format to create an issue on discord, please check and follow the same.

Thank you, could you link me the discord server? I am not on it

HeyAnirudh commented 2 years ago

currently the application has hard coded values to paths of files: 'C:\Users\Admin\Desktop\github\certificates_streamlit\pics\apricus.png') and "images\img.png")

the problem is that they are hard coded for a particular windows machine. Use the OS module to remove the hard-coded values, and provide a layer of abstraction so that the application also works on other operating systems

hey @Beatrix-droid I have given a proper format to create an issue on discord, please check and follow the same.

Thank you, could you link me the discord server? I am not on it

are you a part of HSOC22?

Beatrix-droid commented 2 years ago

currently the application has hard coded values to paths of files: 'C:\Users\Admin\Desktop\github\certificates_streamlit\pics\apricus.png') and "images\img.png")

the problem is that they are hard coded for a particular windows machine. Use the OS module to remove the hard-coded values, and provide a layer of abstraction so that the application also works on other operating systems

hey @Beatrix-droid I have given a proper format to create an issue on discord, please check and follow the same.

Thank you, could you link me the discord server? I am not on it

are you a part of HSOC22?

I am not. I am a web developer in england, just starting my first job, I like contributing to open source in my spare time

HeyAnirudh commented 2 years ago

currently the application has hard coded values to paths of files: 'C:\Users\Admin\Desktop\github\certificates_streamlit\pics\apricus.png') and "images\img.png")

the problem is that they are hard coded for a particular windows machine. Use the OS module to remove the hard-coded values, and provide a layer of abstraction so that the application also works on other operating systems

hey @Beatrix-droid I have given a proper format to create an issue on discord, please check and follow the same.

Thank you, could you link me the discord server? I am not on it

are you a part of HSOC22?

I am not. I am a web developer in england, just starting my first job, I like contributing to open source in my spare time

oh that's great!! thank you for contributing. I see you have raised a pr, I have commented my suggestion in it please have a check on it,.