search

HeyAnirudh / Certificate-Generator

Making certificates is a tiresome job , lets automate it with python and opencv!!
3 stars 6 forks source link

fixes #7 Beatrix-droid removed hard coded paths to files #8

Open Beatrix-droid opened 2 years ago

Beatrix-droid commented 2 years ago

Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems. With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded. Test the app and let me know if it works on windows too

HeyAnirudh commented 2 years ago

Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems. With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded. Test the app and let me know if it works on windows too

hey this doesn't work on windows environment. try using (images/image_name)

Beatrix-droid commented 2 years ago

Removed unnecessary imports and used the OS module to remove all instances of hard coded paths to files, as some paths were hard coded for windows computers and wouldn't have worked on Unix or Unix like systems. With this layer of abstraction, the app now runs on linux, and should be able to run on windows as well, as no values are hardcoded. Test the app and let me know if it works on windows too

hey this doesn't work on windows environment. try using (images/image_name)

I have updated the PR to reflect the changes you asked for

Beatrix-droid commented 2 years ago

I have checked it works!