search

HeyParkerJ / Fantasy-Power-Rankings

A now deprecated webapp for my Fantasy Football league. The core feature allows the league to submit a Coach's Poll style power rank every week with an aggregated report.
3 stars 2 forks source link

App needs real auth #8

Open HeyParkerJ opened 6 years ago

HeyParkerJ commented 6 years ago

Currently, the app/server does a really dumb check to see if the user selected and the pass submitted matches on the server and then returns true or whatever. This isn't a very high priority because it's just our league and these guys aren't smart enough to do any foul play, but if we ever enter a world where other leagues might want to use this, implementing JWT or something would save us from having just about the second worst type of auth you can have.

Requirements: Auth tokens are distributed by the server and compared when user submits their rankings for the week.

GabrielFabian commented 6 years ago

+1 for http://www.passportjs.org/

HeyParkerJ commented 6 years ago

I'll call you about this soon methinks. I admit that this is one of the areas I envisioned building from 'relatively scratch' caveman style just for the learning experience before turning around and actually using a better solution-in-a-box.