KernelDeimos
commented
4 months ago This is my attempt so far to connect the streams. Unfortunately this is more complex than a call to .pipe() because of how node.js streams and the Streams API differ.
My attempt fails as soon as ctx.externs.out.write(chunk) is called on the callback passed to out.on('data', ...); the error says the stream is closed, but that shouldn't happen because I didn't see the output from console.log('DONE WAITING') (or even the output from console.log('WAITING')).
at the end of execute(ctx), after changing spawnSync to spawn;
const out = new stream.PassThrough();
const err = new stream.PassThrough();
const in_ = new stream.PassThrough();
out.on('data', (chunk) => {
ctx.externs.out.write(chunk);
});
err.on('data', (chunk) => {
ctx.externs.err.write(chunk);
});
const fn_err = label => err => {
console.log(`ERR(${label})`, err);
};
out.on('error', fn_err('out'));
err.on('error', fn_err('err'));
child.stdout.on('error', fn_err('stdout'));
child.stderr.on('error', fn_err('stderr'));
child.stdin.on('error', fn_err('stdin'));
// pipe streams to child process
// out.pipe(child.stdin);
child.stdout.pipe(out);
child.stderr.pipe(err);
let rslv_sigint;
const p_int = new Promise(rslv => rslv_sigint = rslv);
ctx.externs.sig.on((signal) => {
if ( signal === signals.SIGINT ) {
rslv_sigint({ is_sigint: true });
}
});
let data, done;
const next_data = async () => {
let is_sigint = false;
({ value: data, done, is_sigint } = await Promise.race([
p_int, in_.read(),
]));
if ( is_sigint ) {
console.log('SIGINT HAPPENED HERE');
throw new Exit(130);
}
// ({ value: line, done } = await in_.read());
}
for ( await next_data() ; ! done ; await next_data() ) {
console.log('WRITING SOMETHING')
child.stdin.write(data);
}
// wait for the child to exit
console.log('WAITING');
await new Promise((resolve, reject) => {
child.on('exit', (code) => {
ctx.externs.out.write(`Exited with code ${code}`);
if (code === 0) {
resolve();
} else {
reject(new Error(`Exited with code ${code}`));
}
});
});
console.log('DONE WAITING');
AtkinsSJ
This checks for the given command name in each directory in $PATH, and returns an object for executing the first match it finds.
This executing is very basic: the command is run, and the arguments are passed to it, and we wait for it to exit before continuing. But we don't connect stdin, stdout, or stderr. (Because I couldn't figure out how to make a Node stream that works. :sweat_smile:)
Slight progress towards #14.