search

HeyPuter / phoenix

🔥 Puter's pure-javascript shell
https://puter.com/app/terminal
GNU Affero General Public License v3.0
90 stars 15 forks source link

Run tests on CI #41

Closed AtkinsSJ closed 7 months ago

AtkinsSJ commented 7 months ago

This is very much just GitHub's suggested node.js workflow file, with the node and action versions changed. I don't know what our minimum requirements are, but their defaults of versions 14.x, 16.x, and 18.x, all failed from missing APIs. As of right now, 20.x and 21.x are both current/active in the release schedule: https://nodejs.org/en/about/previous-releases#release-schedule

The build and tests are run whenever a PR is pushed, and whenever commits are pushed to trunk.

AtkinsSJ commented 7 months ago

I expect CI won't run here by default, but you can look at it running on my fork here: https://github.com/AtkinsSJ/phoenix/actions/runs/8139807548?pr=1

KernelDeimos commented 7 months ago

This seems sensible, thanks!