search

HeyPuter / puter

🌐 The Internet OS! Free, Open-Source, and Self-Hostable.
https://puter.com
GNU Affero General Public License v3.0
26.55k stars 1.75k forks source link

Error when running Putter #203

Closed ManucrackYT closed 7 months ago

ManucrackYT commented 7 months ago

Screenshot_2024-04-01-02-09-33-506_com android chrome

AtkinsSJ commented 7 months ago

This suggests that process.stdout.columns is set to 0 for some reason. generateSeparator() probably does need to handle terminal widths that are less than the text's length, but even so, it's odd to get a 0 here.

ManucrackYT commented 7 months ago

I didnt touch anything, it just loaded that

KernelDeimos commented 7 months ago

The latest commit patches this issue and makes this work properly in very small terminal widths, which is where I'm able to reproduce the error.

However, you don't have a very small terminal width in your screenshot. You're likely to encounter visual glitches which could potentially make the dev console unusable even if you don't get this exception thrown. If you provide the following I'll investigate further:

ManucrackYT commented 7 months ago

I'm using a NodeJS server, made on Pterodactyl. This is hosted on Debian 11

AtkinsSJ commented 7 months ago

OK, looks like Pterodactyl uses Docker internally, so this would apply:

I figured it out - Docker doesn't provide the terminal width so this is actually expected behavior https://github.com/HeyPuter/puter/issues/208#issuecomment-2031381495

So we just need to make sure nothing assumes that the terminal size is reasonable.

ManucrackYT commented 7 months ago

Everything works with the latest Puter version, thanks